Feat(rust): Implement WebVTT-specific timestamp format and layout anchor#2135
Open
pranavshar223 wants to merge 2 commits intoCCExtractor:masterfrom
Open
Feat(rust): Implement WebVTT-specific timestamp format and layout anchor#2135pranavshar223 wants to merge 2 commits intoCCExtractor:masterfrom
pranavshar223 wants to merge 2 commits intoCCExtractor:masterfrom
Conversation
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 6f7ce27...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 6f7ce27...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Description
While auditing the Rust output sinks in preparation for the GSoC "Add Japanese Support" project, I noticed the WebVTT engine (
g608.rs) was generating pseudo-WebVTT files using legacy SubRip (.srt) formatting constraints.Specifically:
,separator for milliseconds instead of the WebVTT standard period..-->line and immediately printed theCRLF, leaving no architectural room to inject WebVTT cue settings (likevertical:rloralign:startwhich are strictly required for vertical Japanese text).Changes Made
context.write_format == CCX_OF_WEBVTT..millisecond separator.align:start line:100%) to the WebVTT timestamp line. This serves as the foundational injection point for the dynamic coordinate-mapping engine required to support IMSC/WebVTT vertical text layouts.Testing
cargo checkcompiles flawlessly with no warnings.CCX_OF_WEBVTTthrough the raw C-binding context safely.