Open
Conversation
Re-introduce Win32 platform configurations to support 32-bit Windows, which was dropped in 2023. This enables CCExtractor to run on 32-bit Windows 10 systems. Changes: - Add Win32 (x86) platform to VS solution and project configs - Make vcpkg triplet conditional (x86-windows-static for Win32) - Update rust.bat to support i686-pc-windows-msvc via RUST_TARGET env var - Add preprocessor conditional in installer.wxs for ProgramFilesFolder - Convert CI build workflow to matrix strategy (x64 + x86) - Update release workflow to produce both x64 and x86 installers Closes #2116 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Looks as though there are just a couple of missing .h files...right? Oh...tip of the iceberg. |
On 64-bit Windows, choco install gpac --forcex86 installs to C:\Program Files (x86)\GPAC, not C:\Program Files\GPAC. - Add configurable GpacDir MSBuild property (defaults to C:\Program Files\GPAC) - Replace all hardcoded GPAC paths with $(GpacDir) - Pass correct GpacDir from CI matrix for x86 builds Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MSBuild places Win32 output in windows/Release-Full/ (no platform prefix), while x64 goes to windows/x64/Release-Full/. Use matrix outdir variable to reference the correct output location. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
upload-artifact rejects '.' in paths. Use "x64/" and "" instead so paths resolve to ./windows/x64/Release-Full and ./windows/Release-Full. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
RUST_TARGETenv var (defaults to x86_64-pc-windows-msvc)ProgramFilesFolderinstead ofProgramFiles64Folderfor x86 buildsKnown risks
--forcex86); if that fails we'll need to build GPAC from source or download x86 binaries separatelystd::arch::x86imports added in commit 7041441)Test plan
Closes #2116
🤖 Generated with Claude Code