Skip to content

2021.01.20 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sne-5249 wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

2021.01.20 #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions 2021_01_20.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# 2020.11.15

## やったこと

- ガチャAPIでレビューいただいた点の修正
- ユーザー所持キャラクター一覧取得APIの実装

## うまくいったこと

- ユーザー所持キャラクター一覧取得APIの実装まで一応完成しました！
Copy link
Copy Markdown

@y-kishida y-kishida Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいね〜！！
お疲れ様！！
これで終わり？？

Copy link
Copy Markdown
Contributor Author

@sne-5249 sne-5249 Jan 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一応機能としては終わりです！
今はとりあえず動くだけという感じなので、リファクタリング頑張ります💪

Copy link
Copy Markdown
Contributor

@TakumaKurosawa TakumaKurosawa Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

- 昨日に引き続き学習時間を確保できたので、だいぶ進めることができました。

## うまくいかなかったこと＆改善案

-

## ご報告

- リーダブルコード届きました！
Copy link
Copy Markdown
Contributor

@TakumaKurosawa TakumaKurosawa Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おぉ！！！
是非時間あるときに読んでみて欲しい！！！


## 参考になったリンク集