Conversation
Owner
Owner
|
I'm still a little short for full review, but looks great so far. Just no problem on Linux, installed |
trojanobelix
approved these changes
Nov 24, 2025
Collaborator
trojanobelix
left a comment
There was a problem hiding this comment.
Looks great so far. Tested under Visual Studio 2026.
CANopenNode
approved these changes
Nov 24, 2025
Owner
|
Works on Raspberry PI too. Not so smooth, but works correctly. I only had to manually run protoc on ARM64. Nuget package is not properly executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Sorry for the delay.
Profile import is now ready for testing.
Recording.2025-11-21.185541.mp4
In addition to the new function I added some tests in ProfileImportTests.cs that runs tests against a simulated gui. Hoping it can be used more in the future to reduce bugs in the gui
There are hopefully only a few things that differs from the original:
On my 5year old cpu it felt very snappy and I did not notice any problems with the extra work
Will be happy to change back if you disagree, but I think it makes it a little clearer.