src/offline/landuse_inout.F90: Replace write interfaces with direct calls to netCDF#681
Merged
SeanBryan51 merged 1 commit intomainfrom Feb 11, 2026
Merged
src/offline/landuse_inout.F90: Replace write interfaces with direct calls to netCDF#681SeanBryan51 merged 1 commit intomainfrom
SeanBryan51 merged 1 commit intomainfrom
Conversation
abhaasgoyal
reviewed
Feb 10, 2026
abhaasgoyal
reviewed
Feb 10, 2026
abhaasgoyal
approved these changes
Feb 10, 2026
Contributor
abhaasgoyal
left a comment
There was a problem hiding this comment.
Overall LGTM, just had couple of queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a bug fix and also a refactor. Currently, enabling the land use scheme (via
l_landuse) causes the following error when writing out the land use restart file:This is because the incorrect netCDF file ID is used in
cable_output.F90when writing the land use restart file:CABLE/src/offline/cable_output.F90
Line 51 in b2d3f8d
Rather than fixing this directly, this change replaces all calls to cable_write.F90 procedures with direct calls to netCDF. This is done so that in the future we can safely replace
cable_output.F90andcable_write.F90with a renewed output module as part of the parallel I/O output module changes (see #641 and #655).Note that the land use scheme is not yet currently functional, even with these changes, as
landuse3.F90is partially implemented.Type of change
Please delete options that are not relevant.
Checklist
Testing
📚 Documentation preview 📚: https://cable--681.org.readthedocs.build/en/681/