Implement first storage layer#72
Conversation
Sync Develop with main again
…ssing-tests 40 reviewing and adding missing tests
* chore: auto-format to pass CI checks * chore(43): delete create_pr.py Add research for the first forecasting approach for ARGUS market time-series data. Remove out-of-scope PR automation script before merging. --------- Co-authored-by: Lev Gusiev <89646710+BytecodeBrewer@users.noreply.github.com>
Update the contributing
Research database
Add docker setup
Define data model
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90e11de118
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Build the Docker image: | ||
|
|
||
| ```bash | ||
| docker build -t argus . |
There was a problem hiding this comment.
On Linux/CI this documented docker build -t argus . command looks for the default file named Dockerfile; Docker’s docs specify alternate names require --file. Since this commit added the file as lowercase dockerfile, users following these instructions will fail before the image builds unless the file is renamed or the command is changed to include -f dockerfile.
Useful? React with 👍 / 👎.
| if result is None: | ||
| return False | ||
|
|
||
| assert result is not None |
There was a problem hiding this comment.
In CI or any offline/rate-limited environment, this assertion now turns a transient live Yahoo/yfinance failure into a hard test failure because prepare_trend_analysis() calls get_timeseries(), which returns None on exceptions or empty responses. The existing yfinance client tests already mock this dependency, so this service test should do the same instead of requiring an external request to succeed.
Useful? React with 👍 / 👎.
3 participants
What changed?
Related issue
Closes #38
Tests
pytestChecklist
Notes