Skip to content

perf: prefetch collections so ObjectId lookup menu opens instantly #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ByteExceptionM merged 1 commit into from
May 6, 2026
Merged

perf: prefetch collections so ObjectId lookup menu opens instantly #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions src/renderer/src/features/collection/DocumentTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,14 @@ export function DocumentTable({
const lastClickedIdRef = useRef<string | null>(null)
const openTab = useTabsStore((s) => s.open)

// Prefetched in the background as soon as the table mounts so the
// ObjectId-lookup submenu (right-click on an ObjectId cell) doesn't have to
// wait on a fresh `listCollections` round-trip. listCollections with
// `nameOnly: true` is cheap, and the cache is shared across tabs of the
// same DB.
const collectionsQuery = useQuery({
queryKey: queryKeys.collections(connectionId, db),
queryFn: () => api.collections.list({ connectionId, db }),
enabled: activeLookup?.ref.kind === 'oid'
queryFn: () => api.collections.list({ connectionId, db })
})

/** User-set widths; auto-estimated widths fill in for the rest. */
Expand Down Expand Up @@ -474,17 +478,23 @@ export function DocumentTable({
Lookup ObjectId in…
</ContextMenuSubTrigger>
<ContextMenuSubContent className="max-h-72 overflow-y-auto">
{collectionsQuery.isLoading && (
<ContextMenuItem disabled>
<Loader2 className="h-4 w-4 animate-spin" />
Loading…
</ContextMenuItem>
)}
{(() => {
const others = (collectionsQuery.data ?? []).filter(
(c) => c.name !== coll
)
if (collectionsQuery.isLoading) return null
if (collectionsQuery.isPending) {
return (
<ContextMenuItem disabled>
<Loader2 className="h-4 w-4 animate-spin" />
Loading…
</ContextMenuItem>
)
}
if (collectionsQuery.isError) {
return (
<ContextMenuItem disabled>
Failed to load collections
</ContextMenuItem>
)
}
const others = collectionsQuery.data.filter((c) => c.name !== coll)
if (others.length === 0) {
return (
<ContextMenuItem disabled>No other collections</ContextMenuItem>
Expand Down
Loading