ci: verify npm publication before release cleanup - #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/npm-v*branches the only npm publish triggerv*tag trigger that could re-run the same publish workflow after the release branch creates its tagnpm publishWhy
The release branch already owns the full publication transaction: verify, test, pack, npm publish, tag, GitHub release, and branch cleanup. Listening to the generated
v*tag as a second publish trigger can create a redundant follow-up run whose existing-tag guard necessarily fails.The workflow also previously trusted the
npm publishprocess exit alone. Registry propagation is now checked explicitly with boundednpm view <package>@<version> versionretries before the release is finalized.Scope
Release CI only. Runtime/package source is unchanged.