fix: report stable no-now due time correctly - #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/loop-statuscount the first--no-nowinterval fromcreatedAtwhenimmediate === falselastRunAt + intervalsrc/index.jsfrom the updated stable sourcesafe_shell_blockedstate instead of assuming a fixed 400 ms runner delayWhy
PR #107 fixed the scheduler so
--no-nowdelays the first run untilcreatedAt + interval, but stable/loop-statusstill calculated fromlastRunAt || 0. A fresh delayed job could therefore displaydue in 0seven though the scheduler correctly intended to wait for the first interval.The V2 status path already follows the correct first-interval semantics; this brings stable status reporting into parity without changing scheduler behavior.
During exact-head Bundle Gate validation, Windows real-host and the normal Windows CI suite passed, but the source-built bundle regression hit a timing-only comprehensive assertion: it read the
rm -r -fsafety state before the idle-safe scheduler had persistedsafe_shell_blocked. The test now uses its existing boundedwaitForValuehelper for that state, preserving the safety assertion while removing runner-speed dependence.Scope
Status display correctness, generated stable bundle synchronization, and deterministic test timing. No scheduling semantics change.