fix(ci): correct desktop path filter scope - #26
Merged
Conversation
Signed-off-by: Brian Charbonneau <github@briancharbonneau.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the CI Desktop path filter so mobile, documentation, and Beads-only changes do not activate Desktop jobs.
Root cause
The filter used
desktop/**plus!desktop/src-tauri/**whiledorny/paths-filterusespredicate-quantifier: some. Each rule is therefore independent, and the negative rule matches every file outsidedesktop/src-tauri.TDD remediation
mainDetect Changed Pathscontract commands passedThe replacement is one positive extglob:
desktop/!(src-tauri)/**. Tauri paths remain covered by the existingdesktop-rustfilter and downstream job conditions.Documentation
ios-buzz-59e.8Promotion
The user explicitly authorized this PR and promotion after review of the hosted-runner consequence. Require all checks green before squash merge.