Skip to content

sqf: lint s31 - isNil/getVar#1090

Draft
PabstMirror wants to merge 1 commit intomainfrom
getvar
Draft

sqf: lint s31 - isNil/getVar#1090
PabstMirror wants to merge 1 commit intomainfrom
getvar

Conversation

@PabstMirror
Copy link
Copy Markdown
Collaborator

ref acemod/ACE3#11083
Not sure about this, it's a little faster
but can't handle _z = nil; _z isNil "x" so it's not always safe to replace

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.6%. Comparing base (483f253) to head (d94719b).
⚠️ Report is 131 commits behind head on main.

Files with missing lines Patch % Lines
...ibs/sqf/src/analyze/lints/s31_isnil_getvariable.rs 25.2% 71 Missing ⚠️
...qf/src/analyze/lints/s26_short_circuit_bool_var.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...qf/src/analyze/lints/s26_short_circuit_bool_var.rs 72.2% <0.0%> (ø)
...ibs/sqf/src/analyze/lints/s31_isnil_getvariable.rs 25.2% <25.2%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant