Skip to content

[bugfix] Fix progress bar accuracy for VFR videos #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathanmdan wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

[bugfix] Fix progress bar accuracy for VFR videos #562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion scenedetect/scene_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,7 @@ def detect_scenes(
)
decode_thread.start()
frame_im = None
prev_position = None

logger.info("Detecting scenes...")
try:
Expand All @@ -581,13 +582,22 @@ def detect_scenes(
if next_frame is not None:
frame_im = next_frame
assert frame_im is not None
if prev_position is None:
prev_position = self._start_pos
assert prev_position is not None
new_cuts = self._process_frame(position, frame_im, callback)
if progress_bar is not None:
if new_cuts:
progress_bar.set_description(
PROGRESS_BAR_DESCRIPTION % len(self._cutting_list), refresh=False
)
progress_bar.update(1 + frame_skip)
# Increment progress bar by delta of position.frame_num instead of 1
# to handle VFR video where frame count is an approximation.
# First frame increments by 1 as base case.
delta_pos = position.frame_num - prev_position.frame_num
is_first_frame = position.frame_num == 0
progress_bar.update((1 if is_first_frame else delta_pos) + frame_skip)
prev_position = position
finally:
if progress_bar is not None:
progress_bar.set_description(
Expand Down
Loading