Skip to content

AB#43 Sonar medium issues. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BlaiseD merged 2 commits into from
Feb 16, 2026
Merged

AB#43 Sonar medium issues. #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f8bd2f
AB#43 Sonar menium issues.
BlaiseD Feb 16, 2026
bcdebd2
AB#43 SonarQube quality status badge.
BlaiseD Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions LogicBuilder.ComponentModel.Design.Serialization.Tests/DesignerSerializationManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,22 @@ public void CreateInstance_ThrowsSerializationExceptionForMissingConstructor()
}
}

[Fact]
public void CreateInstance_ThrowsSerializationExceptionForMissingConstructor_WithNullParameters()
{
// Arrange
var manager = (IDesignerSerializationManager)new DesignerSerializationManager();

// Act & Assert
using (((DesignerSerializationManager)manager).CreateSession())
{
var exception = Assert.Throws<System.Runtime.Serialization.SerializationException>(() =>
manager.CreateInstance(typeof(TestClassWithConstructor), null, "test", false));

Assert.Contains("TestClassWithConstructor", exception.Message);
}
}

[Fact]
public void CreateInstance_ConvertsParametersForConstructor()
{
Expand Down
6 changes: 3 additions & 3 deletions LogicBuilder.ComponentModel.Design.Serialization/DesignerSerializationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ protected virtual object CreateInstance(Type type, ICollection arguments, string
{
StringBuilder stringBuilder = new();
object[] array4 = array;
for (int l = 0; l < array4.Length; l++)
for (int l = 0; array4 != null && l < array4.Length; l++)
{
object obj2 = array4[l];
if (stringBuilder.Length > 0)
Expand Down Expand Up @@ -630,7 +630,7 @@ public object GetSerializer(Type objectType, Type serializerType)
Type runtimeType2 = this.GetRuntimeType(designerSerializerAttribute.SerializerTypeName);
if (runtimeType2 != null)
{
obj = Activator.CreateInstance(runtimeType2, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.CreateInstance, null, null, null);
obj = Activator.CreateInstance(runtimeType2, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.CreateInstance, null, null, null);// NOSONAR
break;
}
}
Expand All @@ -653,7 +653,7 @@ public object GetSerializer(Type objectType, Type serializerType)
type = this.GetRuntimeType(defaultSerializationProviderAttribute.ProviderTypeName);
if (type != null && typeof(IDesignerSerializationProvider).IsAssignableFrom(type))
{
IDesignerSerializationProvider designerSerializationProvider = (IDesignerSerializationProvider)Activator.CreateInstance(type, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.CreateInstance, null, null, null);
IDesignerSerializationProvider designerSerializationProvider = (IDesignerSerializationProvider)Activator.CreateInstance(type, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.CreateInstance, null, null, null);// NOSONAR
((IDesignerSerializationManager)this).AddSerializationProvider(designerSerializationProvider);
}
}
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
[![Build Status](https://github.com/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/actions/workflows/ci.yml/badge.svg)](https://github.com/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/actions/workflows/ci.yml)
[![CodeQL](https://github.com/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/actions/workflows/github-code-scanning/codeql/badge.svg)](https://github.com/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/actions/workflows/github-code-scanning/codeql)
[![codecov](https://codecov.io/gh/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/graph/badge.svg?token=PFDB2PEVZT)](https://codecov.io/gh/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization)
[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=BpsLogicBuilder_LogicBuilder.ComponentModel.Design.Serialization&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=BpsLogicBuilder_LogicBuilder.ComponentModel.Design.Serialization)
[![NuGet](https://img.shields.io/nuget/v/LogicBuilder.ComponentModel.Design.Serialization.svg)](https://www.nuget.org/packages/LogicBuilder.ComponentModel.Design.Serialization)

## Serialization Management
Expand Down