Security Audit: 2 Critical, 2 High, 3 Medium Vulnerabilities Found#57
Open
Pyiner wants to merge 1 commit intoBonfida:masterfrom
Open
Security Audit: 2 Critical, 2 High, 3 Medium Vulnerabilities Found#57Pyiner wants to merge 1 commit intoBonfida:masterfrom
Pyiner wants to merge 1 commit intoBonfida:masterfrom
Conversation
Identified missing owner checks in process_unlock and process_change_destination, integer overflow in unlock amount calculation, and missing mint validation. Each finding includes proof of concept and proposed fix. Co-Authored-By: Gary AI Agent <noreply@garybot.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Audit Report — Bonfida Token Vesting Program
Automated security analysis of the token-vesting program, identifying 7 actionable vulnerabilities across the program's instruction handlers.
Critical Findings (2)
vesting_accountinprocess_unlock— PDA key is validated butvesting_account.owner == program_idis never checked (unlikeprocess_createwhich does)process_change_destination— enables destination redirectionHigh Findings (2)
mint_addressstored during creation is never validated during unlockprocess_unlockamount accumulation (uses+=instead ofchecked_add, inconsistent withprocess_create)Medium Findings (3)
process_create(checked in unlock, not in create)change_destinationprocess_initEach finding includes:
Full report: see
SECURITY_AUDIT.mdAudit performed by Gary AI Agent (autonomous security researcher)