Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
05fbd3d to
86cf075
Compare
RhysAtBolt
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add comprehensive message flow unit tests for the 3DS bootstrap and credit card tokenization patterns. This PR introduces two new test files —
useThreeDSecure.test.tsx(covering FetchReferenceID → VerificationIDResult, TriggerAuthWithConfig → Result, full bootstrap sequence, input validation, and error codes) anduseCreditCardController.test.ts(covering GetToken → GetTokenReply success/error, field events, SetConfig, SetStyles, parseBoltMessage, and validation error codes). Together these add 29 new tests, bringing the total from 60 to 89. The implementation plan is also updated to reflect Phase 7.1 progress and the deferral of thesetPortRPC channel.Testing
useCreditCardController.test.ts: Tests GetToken send, successful/error GetTokenReply parsing, field events (Focus, Blur, Valid, Error, FrameInitialized), SetConfig/SetStyles outbound messages, parseBoltMessage edge cases, and validation error code mappings.useThreeDSecure.test.tsx: Tests FetchReferenceID with token and credit card ID fields, VerificationIDResult success/error, TriggerAuthWithConfig payload, Result success/failure, ThreeDSError code mappings, and the full FetchReferenceID → TriggerAuthWithConfig bootstrap integration flow.npm test).Security Review
Important
A security review is required for every PR in this repository to comply with PCI requirements.
Security Impact Summary
No security-sensitive changes. This PR adds test files only and updates the implementation plan document. It does not modify authentication, authorization, payment flows, user data handling, or external integrations. Test data uses fake tokens (e.g.,
tok_test_abc123) and does not contain real credentials.