VV: Read Oxford Instr. EBSD Data (.ctf) fully V&V'ed

[imikejackson]

Summary

Full V&V of ReadCtfDataFilter per the v2 MTR V&V policy, structured like the ReadAngDataFilter cycle (#1657). Correctness was established against an independent Class 1 (Analytical) + Class 4 (Invariant) oracle before any legacy comparison; EbsdLib 3.1.0's CtfReader is the trusted Class 2 boundary and is not re-tested.

• Bugs fixed: 3D multi-slice .ctf files were silently truncated to slice 0 (legacy read the full volume — support restored, bit-identical to 6.5.171 on the 3D fixture); Euler +30°/degrees-to-radians math now uses double-precision intermediates (correctly-rounded float32 results, bit-identical to 6.5.171 — 543,950 of 660,000 production-scan Euler values match exactly, the remainder being the documented unindexed-point deviation).
• Robustness: six malformed-input guards (-19600…-19605) replace paths where 6.5.171 demonstrably segfaults (missing data column; Phases 0 header — both exit 139) or silently emits heap-dependent output (out-of-range phase value).
• Deviations from 6.5.171: 4 documented entries (vv/deviations/ReadCtfDataFilter.md) — D1 unindexed points keep Phases == 0 (deliberate, PR BUG: ReadCTFData-Remove phase data adjustment. #937), D2 consequent +30° difference on unindexed φ2, D3 malformed-input behavior, D4 3D truncation (fixed/retired). No legacy patch required; every root cause proven from source plus demonstration runs.
• Tests: the legacy-oracle exemplar test and 6_6_read_ctf_data_2.tar.gz are retired; replaced by 12 TEST_CASEs on inline hand-authored fixtures with hand-derived expected values, including Euler angles chosen where float32 and double roundings differ (pins the precision fix), an exact-boundary phase-range value, and a new SIMPL 6.4/6.5 conversion test.
• Deliverables: report (vv/ReadCtfDataFilter.md, READY FOR REVIEW), deviations, and provenance sidecar documenting the archive retirement. Filter docs updated (φ2 wording fix, 3D/unindexed/memory/migration sections).
• Hardened via adversarial, senior-engineer, CPU, memory, and out-of-core review passes; ReadAngData.hpp aligned to the FileSystemPathParameter::ValueType alias convention.

Test Plan

• ctest -R "OrientationAnalysis::ReadCtfDataFilter" — 12/12 pass (in-core simplnx-Rel)
• Same 12/12 pass in the out-of-core build (simplnx-ooc-Rel)
• Full OrientationAnalysis suite — 263/263 pass
• A/B vs official DREAM3D 6.5.171 PipelineRunner on toy, production (Cugrid 550×400), and 3D fixtures — bit-identical outside documented deviations (artifacts archived to OneDrive per policy, not committed)