VV: ComputeFeatureReferenceCAxisMisorientations fully V&V'ed#1636
Open
imikejackson wants to merge 1 commit into
Open
VV: ComputeFeatureReferenceCAxisMisorientations fully V&V'ed#1636imikejackson wants to merge 1 commit into
imikejackson wants to merge 1 commit into
Conversation
Summary:
- Confirmed no SIMPLNX-side bugs (algorithm correctly handles
all-non-hex feature via IEEE 754 NaN propagation; D1 + D4 below are
pre-existing legacy bugs already fixed in SIMPLNX via PR BlueQuartzSoftware#1438 + PR
BlueQuartzSoftware#1472);
- documented 2 deviations from DREAM3D 6.5.171 (D1 legacy lacks isHex
gate → garbage non-hex cell values + non-NaN avg, D4 hand-rolled
MatrixMath + float32 stddev precision drift ~1e-4° per cell) — both
already closed on v6_5_172 via pre-existing backport commits
d4b5509aa + 4435d1997, three-way A/B confirms 6.5.172 ≡ SIMPLNX
byte-for-byte;
- retired 1 test (Valid Filter Execution — circular oracle on
caxis_data.tar.gz exemplar; archive download retained because
ComputeCAxisLocationsTest still consumes it);
- unit tests replaced with 4 inlined *Class 1 (Analytical) + Class 4
(Invariant)* test fixtures (Simple Hex Triple + Realistic
Microstructure exposes-all-non-hex-feature + All-Identical
Orientation + Invariants sweep);
- added 3 V&V source-tree deliverables (report, deviations, provenance).
imikejackson
force-pushed
the
vv/compute_feature_ref_c_axis
branch
from
cf0ca21 to
7328371
Compare
nyoungbq
approved these changes
Jun 11, 2026
|
|
||
| --- | ||
|
|
||
| ## ComputeFeatureReferenceCAxisMisorientationsFilter-D4 |
Contributor
There was a problem hiding this comment.
Unclear numbering scheme it goes from D1 straight to D4
| | **Filter UUID** | `16c487d2-8f99-4fb5-a4df-d3f70a8e6b25` | | ||
| | **Status** | active (SIMPLNX fixed pre-V&V via PR #1438; legacy 6.5.171 still has the bug — backported to `v6_5_172` branch in commit `d4b5509aa`) | | ||
|
|
||
| **Symptom:** Per-cell and per-feature outputs for non-hex features differ between SIMPLNX and DREAM3D 6.5.171. Legacy 6.5.171 computes a c-axis projection misorientation for *every* cell regardless of crystal structure, producing meaningless numeric values for non-hex cells (the projection treats the cubic cell's quaternion as if it were hex). For a feature whose cells are *all* non-hex, the legacy filter produces `featAvg = 0.0 or whatever-the-projection-yields` instead of the analytically-correct `NaN` — the per-cell loop accumulates numeric values into the avg, and the final division produces a finite result. The per-feature population stddev follows the same garbage pattern. |
Contributor
There was a problem hiding this comment.
Suggested change
| **Symptom:** Per-cell and per-feature outputs for non-hex features differ between SIMPLNX and DREAM3D 6.5.171. Legacy 6.5.171 computes a c-axis projection misorientation for *every* cell regardless of crystal structure, producing meaningless numeric values for non-hex cells (the projection treats the cubic cell's quaternion as if it were hex). For a feature whose cells are *all* non-hex, the legacy filter produces `featAvg = 0.0 or whatever-the-projection-yields` instead of the analytically-correct `NaN` — the per-cell loop accumulates numeric values into the avg, and the final division produces a finite result. The per-feature population stddev follows the same garbage pattern. | |
| **Symptom:** Per-cell and per-feature outputs for non-hex features differ between SIMPLNX and DREAM3D 6.5.171. Legacy 6.5.171s c-axis projection treats every cubic cell's quaternion as if it were hex. For a feature whose cells are *all* non-hex, the legacy filter produces `featAvg = 0.0 or whatever-the-projection-yields` instead of the analytically-correct `NaN`. The issue exists in the per-feature population stddev calculation as well. |
This needs to be consolidated see above for example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.