This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Revert "Fix buffering when reporting dt < 0.1 (#35)"#38
Merged
jorblancoa merged 1 commit intomasterfrom Jan 20, 2023
Merged
Conversation
This reverts commit 648485c.
Collaborator
Author
|
This needs to be reverted until BlueBrain/CoreNeuron#875 is merged A branch with this change is here: https://github.com/BlueBrain/libsonatareport/tree/jblanco/fix_buffering/src |
pramodk
approved these changes
Jan 20, 2023
Contributor
pramodk
left a comment
pramodk
left a comment
There was a problem hiding this comment.
LGTM [the idea would be to have this fix and other pending changes (part-2) to be merged at the same time].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 648485c.