remove cpuinfo dependency and filesystem caching of get_cpu_info call #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmendez
force-pushed
the
feature/remove-cpuinfo
branch
from
4ee2189 to
b1b6fcd
Compare
FrancescAlted
approved these changes
Jan 23, 2026
Member
FrancescAlted
left a comment
FrancescAlted
left a comment
There was a problem hiding this comment.
Great work! Thanks @skmendez !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #356.
This PR removes the dependency on cpuinfo entirely, instead opting to implement the necessary parts of it on our own for Windows, along with the existing macOS and Linux implementations. Since all of these implementations are very performant (each taking sub 10ms), there's no longer a need to cache the result in
_USER_CACHE_DIR, so I've removed that cache and the corresponding dependency onplatformdirs.