Skip to content

feat: add configurable dev server port and timeout settings#1852

Open
benmarten wants to merge 1 commit intoBloopAI:mainfrom
benmarten:vk/cbef-set-port-and-tim
Open

feat: add configurable dev server port and timeout settings#1852
benmarten wants to merge 1 commit intoBloopAI:mainfrom
benmarten:vk/cbef-set-port-and-tim

Conversation

@benmarten
Copy link
Copy Markdown

@benmarten benmarten commented Jan 8, 2026

Screenshot 2026-01-09 at 11 05 31 AM

Summary

  • Adds dev_server_port and dev_server_timeout fields to projects
  • New UI inputs in project settings to configure these values
  • Applied during dev script execution
  • Includes database migration

Test plan

  • Verified settings can be configured in project settings
  • Verified port and timeout are applied to dev script execution
  • Verified migration runs successfully

🤖 Generated with Claude Code

@benmarten benmarten force-pushed the vk/cbef-set-port-and-tim branch from 34b7199 to 9a6b233 Compare January 8, 2026 17:29
@vibe-kanban-cloud
Copy link
Copy Markdown

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

@benmarten benmarten force-pushed the vk/cbef-set-port-and-tim branch 2 times, most recently from 8d59a30 to 4871e73 Compare January 9, 2026 17:20
- Add dev_server_timeout field to projects table (default 30s)
- Allow configuring dev server port in project settings
- Port configuration takes priority over auto-detection from logs
- Add UI controls in Project Settings for port and timeout
- Update preview panel to use configured timeout
@Juanlucasbg
Copy link
Copy Markdown

Rebase verification — PR #1852

Local rebase against current main fails with conflicts in 22 files:

  • 15 sqlx prepared-statement files (crates/db/.sqlx/...)
  • crates/db/src/models/project.rs
  • crates/services/src/services/{container,project}.rs
  • 3 pre-monorepo frontend/src/... paths
  • shared/types.ts (generated)

The "configurable dev server port and timeout settings" feature has a wide surface (DB schema fields → service-layer plumbing → UI controls) and the conflicts span pre-monorepo + sqlx-cache + active-file paths.

Action: this PR's surface is too broad to rebase by hand. Two paths forward:

  1. Close + rewrite as a fresh PR against current main. The feature design is fine; the conflict mechanics aren't.
  2. Cut scope — just the dev server port config (subset of the original PR) and skip the timeout. Smaller surface, easier to land.

Sunset context: #3387 made project routes export-only. The dev-server-config UI may not have a surface anymore.

— Automated rebase-verification: detected 22-file conflict before posting. Recommend close + rewrite or scope cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants