More changes trying to get DpiAware working (BL-16269)#7919
Open
JohnThomson wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the effort to make Bloom’s WinForms/React-based dialogs behave correctly in DPI-aware (PerMonitorV2) scenarios by switching several dialogs from fixed pixel sizing to “logical” sizing that is scaled to the monitor DPI at runtime, and by tightening the scope of legacy DPI context during startup.
Changes:
- Added
ReactDialog.SetScaledSize()and updated manyReactDialogusages to size dialogs using scaled logical dimensions instead of rawWidth/Height. - Adjusted
Program.ChooseACollection()to ensure the legacy DPI scope only applies to the collection chooser dialog, while opening the main shell happens in normal PerMonitorV2 context. - Updated ownership/positioning patterns for a few dialogs (e.g., problem report and team collection progress) to better align sizing with the intended owner window.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BloomExe/Workspace/WorkspaceView.cs | Auto-update dialog now uses scaled logical sizing. |
| src/BloomExe/web/controllers/ProblemReportApi.cs | Problem report dialog now scales size and reuses a computed owner. |
| src/BloomExe/TeamCollection/TeamCollection.cs | Team collection progress dialog now uses scaled sizing and passes an explicit owner to the progress-dialog runner. |
| src/BloomExe/TeamCollection/FolderTeamCollection.cs | Join team collection dialog now uses scaled logical sizing. |
| src/BloomExe/Program.cs | Limits legacy DPI scope to chooser dialog; opens collection afterward in normal DPI context. |
| src/BloomExe/MiscUI/ReactDialog.cs | Introduces SetScaledSize() and applies scaling in OnLoad. |
| src/BloomExe/MiscUI/BloomMessageBox.cs | Message box dialog now uses scaled logical sizing. |
| src/BloomExe/ErrorReporter/HtmlErrorReporter.cs | Error reporter dialog now uses scaled sizing when it is a ReactDialog, with fallback sizing otherwise. |
| src/BloomExe/Edit/EditingView.cs | Copyright/license dialog now uses scaled logical sizing. |
| src/BloomExe/Edit/EditingModel.cs | Duplicate-many-pages dialog now uses scaled logical sizing. |
| src/BloomExe/Collection/CollectionSettingsDialog.cs | Language chooser dialog now uses scaled logical sizing and reuses a computed owner. |
| src/BloomExe/BloomIntegrityChecker.cs | Integrity-check failure dialog now manually scales size based on DeviceDpi. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+47
to
+64
| // on its actual target monitor | ||
| _desiredLogicalWidth = logicalWidth; | ||
| _desiredLogicalHeight = logicalHeight; | ||
| } | ||
|
|
||
| private int _desiredLogicalWidth = 0; | ||
| private int _desiredLogicalHeight = 0; | ||
|
|
||
| protected override void OnLoad(EventArgs e) | ||
| { | ||
| base.OnLoad(e); | ||
|
|
||
| // Apply the desired size during load, after positioning on the target monitor. | ||
| // Scale the logical dimensions based on the actual DPI of the monitor we're on. | ||
| if (_desiredLogicalWidth > 0 || _desiredLogicalHeight > 0) | ||
| { | ||
| int scaledWidth = (int)Math.Round(_desiredLogicalWidth * DeviceDpi / 96.0); | ||
| int scaledHeight = (int)Math.Round(_desiredLogicalHeight * DeviceDpi / 96.0); |
| dlg.Width = 750; | ||
| // Use logical dialog dimensions and scale them to current monitor DPI. | ||
| // Force handle creation first so DeviceDpi reflects the target display context. | ||
| var unusedHandle = dlg.Handle; |
Comment on lines
2551
to
+2571
| @@ -2560,14 +2562,13 @@ protected void ShowProgressDialog( | |||
| showReportButton = "never", | |||
| }, | |||
| "Sync Team Collection" | |||
| ) | |||
| // winforms dialog properties | |||
| { | |||
| Width = 620, | |||
| Height = 550, | |||
| }, | |||
| ); | |||
| dlg.SetScaledSize(620, 550, owner); | |||
| return dlg; | |||
| }, | |||
| doWhat, | |||
| doWhenMainActionFalse | |||
| doWhenMainActionFalse, | |||
| Shell.GetShellOrOtherOpenForm() | |||
Contributor
Author
There was a problem hiding this comment.
No longer passing to SetScaledSize
| // Normally, I'd want to fail fast and throw an exception if it isn't, | ||
| // but here we're in the middle of reporting an error, so I'd rather we just do our | ||
| // best to show the original error. So we'll go with prior code (and maybe get a poorly sized | ||
| // dialog if scale is not 100%).) |
JohnThomson
force-pushed
the
moreDpiChanges
branch
from
1167442 to
444ff7f
Compare
JohnThomson
force-pushed
the
moreDpiChanges
branch
from
444ff7f to
7b2bd9e
Compare
JohnThomson
commented
May 18, 2026
Contributor
Author
JohnThomson
left a comment
JohnThomson
left a comment
There was a problem hiding this comment.
@JohnThomson made 4 comments and resolved 2 discussions.
Reviewable status: 0 of 12 files reviewed, 2 unresolved discussions.
| dlg.Width = 750; | ||
| // Use logical dialog dimensions and scale them to current monitor DPI. | ||
| // Force handle creation first so DeviceDpi reflects the target display context. | ||
| var unusedHandle = dlg.Handle; |
| // Normally, I'd want to fail fast and throw an exception if it isn't, | ||
| // but here we're in the middle of reporting an error, so I'd rather we just do our | ||
| // best to show the original error. So we'll go with prior code (and maybe get a poorly sized | ||
| // dialog if scale is not 100%).) |
Comment on lines
+47
to
+64
| // on its actual target monitor | ||
| _desiredLogicalWidth = logicalWidth; | ||
| _desiredLogicalHeight = logicalHeight; | ||
| } | ||
|
|
||
| private int _desiredLogicalWidth = 0; | ||
| private int _desiredLogicalHeight = 0; | ||
|
|
||
| protected override void OnLoad(EventArgs e) | ||
| { | ||
| base.OnLoad(e); | ||
|
|
||
| // Apply the desired size during load, after positioning on the target monitor. | ||
| // Scale the logical dimensions based on the actual DPI of the monitor we're on. | ||
| if (_desiredLogicalWidth > 0 || _desiredLogicalHeight > 0) | ||
| { | ||
| int scaledWidth = (int)Math.Round(_desiredLogicalWidth * DeviceDpi / 96.0); | ||
| int scaledHeight = (int)Math.Round(_desiredLogicalHeight * DeviceDpi / 96.0); |
Comment on lines
2551
to
+2571
| @@ -2560,14 +2562,13 @@ protected void ShowProgressDialog( | |||
| showReportButton = "never", | |||
| }, | |||
| "Sync Team Collection" | |||
| ) | |||
| // winforms dialog properties | |||
| { | |||
| Width = 620, | |||
| Height = 550, | |||
| }, | |||
| ); | |||
| dlg.SetScaledSize(620, 550, owner); | |||
| return dlg; | |||
| }, | |||
| doWhat, | |||
| doWhenMainActionFalse | |||
| doWhenMainActionFalse, | |||
| Shell.GetShellOrOtherOpenForm() | |||
Contributor
Author
There was a problem hiding this comment.
No longer passing to SetScaledSize
Contributor
|
devin says src/BloomExe/MiscUI/ReactDialog.cs:R44-50 RegistrationManager.cs still uses direct Width/Height on ReactDialog This PR consistently converts all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is