Conversation
imaginator
left a comment
There was a problem hiding this comment.
you need to link these into the menu
|
@imaginator I updated this and the other PR to replace them with versions that are linked into the menu |
imaginator
left a comment
There was a problem hiding this comment.
as with my other comments... "```rust" will make the code easier to read.
|
Overall 7b7e489 looks good. It is missing two things:
|
|
On Bitcoin standard advice is to never use time-based, only use block-based timelocks, because they're easier to reason about, less miner-gamable, and give you a longer range. Unfortunately on Liquid we inherited Bitcoin's "up to 65535 blocks or up to 65535 512-second intervals" limits. But with blocks coming 1 minute rather than every 10 minutes, this means that block-based relative timelocks are limited to roughly 45 days. If you need a longer timelock you're forced to use time-based ones, which will get you a bit over a year. If you need longer than that you have to use absolute, rather than relative, timelocks. |
|
I'm planning to talk this over with @apoelstra tomorrow and then make some edits based on my deepened understanding of this topic. |
|
I'd recommend not tying Timelock documentation to referencing the Liquid network - timelocks behave in a similar way on non-liquid bitcoin systems. You just need to point out the 65k limit on Liquid. |
|
This turned out to be complicated on several grounds (including bugs we discovered in timelock jets). My preference would be to work this out with @apoelstra when he's back because there are many fine details, including the jet deprecation, to get right. If we do find some people getting stuck with timelock issues, I think @delta1 understands this enough that we could probably work out a minimum viable version. |
Add some material on how relative timelocks using block distance work