common: add taproot singlesig descriptor support#146
Open
Antisys wants to merge 1 commit intoBlockstream:masterfrom
Open
common: add taproot singlesig descriptor support#146Antisys wants to merge 1 commit intoBlockstream:masterfrom
Antisys wants to merge 1 commit intoBlockstream:masterfrom
Conversation
Add `Singlesig::Taproot` variant that generates `eltr` descriptors
with BIP-86 derivation path (`86h/{coin_type}h/0h`).
- Wire `--kind taproot` through CLI, bindings, and WASM
- Add `DescriptorType::Tr` handling for Jade address verification
- Add `WalletType::Taproot` to RPC model
- Fix Ledger `get_receive_address_single` to vary the wallet policy
descriptor by variant — was previously hardcoded to `wpkh(@0/**)`
which also affected the pre-existing `ShWpkh` path
Closes Blockstream#31
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Singlesig::Taprootvariant generatingeltrdescriptors with BIP-86 derivation path (86h/{coin_type}h/0h)--kind taprootthrough CLI, UniFFI bindings, and WASMDescriptorType::Trhandling for Jade address verification andWalletType::Taprootto the RPC modelget_receive_address_singlewallet policy descriptor — was hardcoded towpkh(@0/**)regardless of variant, which also affected the pre-existingShWpkhpathExample generated descriptor:
Closes #31
Test plan
cargo test --lib— all unit tests passcargo clippy --all-targets -- -D warnings— zero warningssinglesig_from_strtest coversFromStrfor all three variantstaproot_singlesig_desc_formattest verifies descriptor format, coin type, and successful parse intoWolletDescriptorfor both mainnet/testnet and Slip77/Elip151🤖 Generated with Claude Code