glcli: new commands to test payments#670
Conversation
| .await | ||
| .map_err(|e| Error::custom(e.message()))? | ||
| .into_inner(); | ||
| println!("{:?}", res); |
There was a problem hiding this comment.
Do you think it'd be possible to annotate the protobuf messages with a JSON serialization, allowing us to return a machine readable JSON object on stdout (and log to stderr) so that we can for example pipe it into jq for scripting? Just wondering if that's somethign that would be easy 🤔
There was a problem hiding this comment.
Also, probably more of a follow-up than a blocker here.
|
ACK 1fa46ea (I know this is still a draft, but wanted to see what's changing :-) ) |
Replace call_raw with call_typed when creating a regular invoice in the LSP invoice handler. This provides better type safety by using the generated cln_rpc::model::requests::InvoiceRequest and cln_rpc::model::responses::InvoiceResponse types. Benefits: - Compile-time type checking for request/response fields - No manual hex decoding needed for payment_hash/payment_secret - Access to created_index field from the response - Cleaner code without custom request/response structs
|
Actually, why is this in draft? Is there more to come or do you think we can just line this one up to be merged, and any followup work can be done in a followup PR? |
cdecker
force-pushed
the
glcli-newaddr
branch
from
cfe6c06 to
0df9d8a
Compare
Lagrang3
force-pushed
the
glcli-newaddr
branch
2 times, most recently
from
5e145ea to
e9251a9
Compare
I wasn't sure about some things. I was also testing. |
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
glcli-newaddr
branch
from
e9251a9 to
961c1c7
Compare
ShahanaFarooqui
force-pushed
the
main
branch
3 times, most recently
from
7185343 to
2fafe20
Compare
2 participants
This PR adds simplified user commands to be able to get funds and open channels, as well as withdraw and close.