Fix recovery pin #294
Open
Fix recovery pin #294
+185
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Set pin flow after recovery video_2026-01-15_12-29-54.mp4 |
Author
|
Add scroll for small screens in security level screen |
nomanr
reviewed
Jan 19, 2026
Contributor
nomanr
left a comment
nomanr
left a comment
There was a problem hiding this comment.
Minor: PR title has a typo - "recovey" should be "recovery".
|
|
||
| @Serializable | ||
| data class RecoverySuccess(val greenWallet: GreenWallet, val isRecoveryConfirmation: Boolean = false) : NavigateDestination() | ||
|
|
Contributor
There was a problem hiding this comment.
Both greenWallet and the isRecoveryConfirmation = false default appear unused. greenWallet isn't used in RecoverySuccessScreen, and isRecoveryConfirmation is always created with true in the router (the else branch is dead code).
| <string name="id_setup_mobile_wallet">Setup Mobile Wallet</string> | ||
| <string name="id_setup_hardware_wallet">Setup Hardware Wallet</string> | ||
| <string name="zid_setup_hardware_wallet">Setup Hardware Wallet</string> | ||
| <string name="id_security_level_">Security Level %1$s</string> |
Contributor
There was a problem hiding this comment.
Is the rename from id_setup_hardware_wallet to zid_setup_hardware_wallet intentional? It looks like a typo. The string doesn't appear to be used anywhere in the codebase, so consider removing it entirely if unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor recovery check navigation logic
Simplified navigation flow and reduced nested conditionals.
Enforce PIN setup after manual backup
Ensures PIN is required after manual backup.
Set a PIN after manual backup flow (align to iOS) #291
Add scroll for small screens in security level screen
Prevents content cutoff on small devices.
UI glitch #272
Remove duplicate / unused resources
Functional fix was already shipped in v5.1.0
(commit: 9a180fa).
This change only removes leftover unused resources.
Small typo. #282