Skip to content

sign_tx: use caller-supplied genesis hash #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
topologoanatom wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

sign_tx: use caller-supplied genesis hash #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions main/process/sign_tx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,20 @@ static void sign_tx_impl(jade_process_t* process, const bool for_liquid)
goto cleanup;
}

// Liquid: Optional caller-supplied genesis hash overrides the hardcoded network default.
// Must be read and copied now while the initial message buffer (params) is still valid.
uint8_t caller_genesis[SHA256_LEN];
bool has_caller_genesis = false;
if (for_liquid) {
const uint8_t* genesis_ptr = NULL;
size_t genesis_ptr_len = 0;
rpc_get_bytes_ptr("genesis_block_hash", &params, &genesis_ptr, &genesis_ptr_len);
if (genesis_ptr && genesis_ptr_len == SHA256_LEN) {
memcpy(caller_genesis, genesis_ptr, SHA256_LEN);
has_caller_genesis = true;
}
}

// Liquid: Gather the (unblinded) output info for user confirmation,
// then validate output and additional_info values
if (for_liquid) {
Expand Down Expand Up @@ -799,9 +813,15 @@ static void sign_tx_impl(jade_process_t* process, const bool for_liquid)
uint8_t genesis_buff[SHA256_LEN], *genesis = NULL;
size_t genesis_len = 0;
if (for_liquid && num_p2tr_to_sign) {
// Liquid: Fetch the genesis blockhash for taproot hash generation
// Liquid: Fetch the genesis blockhash for taproot hash generation.
// Prefer the caller-supplied hash (from sign_liquid_tx params) so that
// non-standard regtest environments (e.g. -initialfreecoins) work correctly.
genesis = genesis_buff;
network_to_genesis_hash(network_id, genesis, sizeof(genesis_buff));
if (has_caller_genesis) {
memcpy(genesis_buff, caller_genesis, SHA256_LEN);
} else {
network_to_genesis_hash(network_id, genesis, sizeof(genesis_buff));
}
genesis_len = sizeof(genesis_buff);
}
for (size_t index = 0; num_p2tr_to_sign != 0 && index < tx->num_inputs; ++index) {
Expand Down