Remove incorrect clustering, I am the sole proprietor and operator of BSP

[leo42]

I am the sole owner and operator of BSP a single pool!

All Submissions:

• Have you followed the guidelines in our Contributing documentation?
• Have you verified that there aren't any other open Pull Requests for the same update/change?
• Does the Pull Request pass all tests?

Description

/* Add a short description of your Pull Request */

Checklist

/* Keep from below the appropriate checklist for your Pull Request and remove the others */

New Ledger Support Submissions:

• What mapping information did you add for the new ledger?
  • identifiers
  • addresses
  • clusters
  • legal links
• Did you create a new parser?
  • If yes, did you create a unit test for the new parser?
  • If no, which parser did you reuse?
    • DefaultParser
    • DummyParser
    • EthereumParser
• Did you create a new mapping?
  • If yes, did you create a unit test for the new mapping?
  • If no, which mapping did you reuse? /* mapping name */
    • DefaultMapping
    • DummyMapping
    • EthereumMapping
    • CardanoMapping
    • TezosMapping
• Did you enable the parser for the new ledger in consensus_decentralization/parse.py?
• Did you enable the mapping for the new ledger in consensus_decentralization/map.py?
• Did you document support for the new ledger as described in our Contributing documentation?

Update Mapping Support Information Submissions:

• For which ledger do you update the mapping information?
  • /* ledger name */
• What mapping information do you update?
  • identifiers
  • addresses
  • clusters
  • legal links
• Did you update the tests (if needed)?

New Metric Support Submissions:

• Did you put the metric's script under consensus_decentralization/metrics?
• Did you name the metric's main function of the script compute_{metric name}?
• Did you import the metric's main function to consensus_decentralization/analyze.py?
• Did you add the new metric (and possible parameter values) to config.yaml?
• Did you write unit tests for the new metric?
• Did you document the new metric in the documentation pages?

[dimkarakostas]

Thanks for the feedback. Can you change the entry in the mapping information file with the correct name, description, and website as well? And then we'll approve and merge this.

[leo42]

Thanks for the feedback. Can you change the entry in the mapping information file with the correct name, description, and website as well? And then we'll approve and merge this.

I added my self to the mapping file.

[dimkarakostas]

LGTM

[LadyChristina]

Hi @leo42, thanks a lot for your input! I understand that your pool is a completely separate entity from Binance and apologies for the mix-up. However, here is the issue: if you run the following query on Big Query it returns multiple pools that are identified by the BSP ticker, some of which are / were operated by Binance.

SELECT ticker_name, json as metadata FROM `iog-data-analytics.cardano_mainnet.pool_offline_data` WHERE ticker_name = "BSP"

We already have a way to identify such conflicts (where multiple pools share the same ticker but have different homepages (see this Cardano conflicts file), but we haven't updated the main mapping info file we use yet because we don't currently have a way of dealing with duplicate tickers.

I'm afraid I can't approve your changes because then many blocks that were created by Binance pools would be attributed to your pool. Instead, we can update our methodology to use another way to identify pools in Cardano, as tickers are not unique. I was about to create a new issue for this, but I just saw that you have already created a relevant issue (sorry for not seeing this sooner, I'll try to update my notification settings as I'm currently not getting any notifications from this repo for some reason).

@dimkarakostas you can share your thoughts too but my opinion is that we can close this PR and shift our focus to updating the methodology, which will take care of this inaccuracy (and possibly others) along the way