Skip to content

ci: add manual @bitgo-beta SDK bump workflow #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranavjain97 wants to merge 1 commit into
base: master
Choose a base branch
from
+94 −0
Open

ci: add manual @bitgo-beta SDK bump workflow #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 94 additions & 0 deletions .github/workflows/bump-sdk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
name: Bump @bitgo-beta SDK Dependencies

on:
workflow_dispatch:

permissions:
contents: write
pull-requests: write

jobs:
bump-sdk:
name: Bump SDK deps and open PR
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
ref: master

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '22.1.0'
cache: 'npm'
Comment on lines +20 to +24
Copy link
Copy Markdown

@gokulhost gokulhost May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '22.1.0'
cache: 'npm'
- name: Get Node.js version from package.json
id: node-version
run: echo "NODE_VERSION=$(jq -r .engines.node package.json)" >> $GITHUB_OUTPUT
- name: Setup Node.js from engines
uses: actions/setup-node@v4
with:
node-version: ${{ steps.node-version.outputs.NODE_VERSION }}
cache: 'npm'

so we do not have to hardcode in CI

Copy link
Copy Markdown
Contributor

@pranishnepal pranishnepal May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat approach! 😮

just a question though: looks like we have engines defined as >= 22.x, so it would mean, the node version retrieved could be 22.x / 23.x/ 24.x; might be hard to reproduce, what do you guys think?

Copy link
Copy Markdown

@gokulhost gokulhost May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valid concern. We should be pinning node versions I guess?


- name: Install current dependencies
run: npm ci

- name: Bump @bitgo-beta versions
run: npm run bump-versions

- name: Regenerate lockfile
Copy link
Copy Markdown
Contributor

@pranishnepal pranishnepal May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor optimization but if we add a step like the following:

- name: Early exit if nothing changed
  run: |
    if git diff --quiet HEAD -- package.json; then
      echo "No version bumps found, exiting."
      exit 0  # or use $GITHUB_OUTPUT to skip remaining steps
    fi

we can early return after the Bump version step

run: npm install --package-lock-only

- name: Install updated dependencies
run: npm ci

- name: Lint
run: npm run lint

- name: Build
run: npm run build

- name: Generate test SSL certificates
run: npm run generate-test-ssl

- name: Test
run: npm test
env:
NODE_OPTIONS: '--max-old-space-size=4096'
MASTER_BITGO_EXPRESS_KEYPATH: ./demo.key
MASTER_BITGO_EXPRESS_CRTPATH: ./demo.crt
MTLS_ENABLED: true
MTLS_REQUEST_CERT: true
MTLS_REJECT_UNAUTHORIZED: false
KEY_PROVIDER_URL: 'https://localhost:3000/'

- name: Check for changes
id: changes
run: |
if git diff --quiet HEAD -- package.json package-lock.json; then
echo "changed=false" >> $GITHUB_OUTPUT
else
echo "changed=true" >> $GITHUB_OUTPUT
fi

- name: Commit and push branch
id: push-branch
if: steps.changes.outputs.changed == 'true'
run: |
DATE=$(date +'%Y-%m-%d')
BRANCH="chore/bump-bitgo-beta-$(date +'%Y%m%d-%H%M')"
git config user.name "github-actions[bot]"
git config user.email "github-actions[bot]@users.noreply.github.com"
git checkout -b "$BRANCH"
git add package.json package-lock.json
git commit -m "chore: bump @bitgo-beta dependencies ${DATE}"
git push origin "$BRANCH"
echo "branch=$BRANCH" >> $GITHUB_OUTPUT
echo "date=$DATE" >> $GITHUB_OUTPUT

- name: Open draft PR
if: steps.changes.outputs.changed == 'true'
run: |
gh pr create \
--title "chore: bump @bitgo-beta dependencies ${{ steps.push-branch.outputs.date }}" \
--body "Automated weekly bump of \`@bitgo-beta/*\` dependencies.

Build and tests passed on this branch before opening." \
--base master \
--head "${{ steps.push-branch.outputs.branch }}" \
--draft
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading