feat(wasm-utxo): size Zcash Orchard/Ironwood shielded outputs via Dimensions - #370
Merged
veetragjain merged 1 commit intoAug 24, 2026
Conversation
veetragjain
marked this pull request as ready for review
August 24, 2026 14:16
OttoAllmendinger
requested changes
Aug 24, 2026
| * receiver should be sized as a shielded output | ||
| */ | ||
| static fromOutput(address: string, network: CoinName): Dimensions; | ||
| static fromOutput(address: string, network: CoinName, isShielded?: boolean): Dimensions; |
Contributor
There was a problem hiding this comment.
let's stay extensible
Suggested change
| static fromOutput(address: string, network: CoinName, isShielded?: boolean): Dimensions; | |
| static fromOutput(address: string, network: CoinName, options?: OutputOptions): Dimensions; |
with OutputOptions = { isShielded?: boolean }
veetragjain
force-pushed
the
veetragjain/cshld-1380-wasm-utxo-orchard-bundle-sizing-in-dimensions
branch
from
August 24, 2026 14:29
d805fc3 to
495eed7
Compare
OttoAllmendinger
approved these changes
Aug 24, 2026
veetragjain
deleted the
veetragjain/cshld-1380-wasm-utxo-orchard-bundle-sizing-in-dimensions
branch
August 24, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CSHLD-1380