feat(wasm-utxo): support multi-recipient Ironwood shielded outputs - #367
Merged
veetragjain merged 1 commit intoAug 24, 2026
Conversation
veetragjain
force-pushed
the
veetragjain/cshld-1529-support-multi-recipient-ironwood-shielded-outputs
branch
3 times, most recently
from
August 21, 2026 15:01
623aa08 to
6b6f417
Compare
veetragjain
force-pushed
the
veetragjain/cshld-1529-support-multi-recipient-ironwood-shielded-outputs
branch
from
August 21, 2026 15:04
6b6f417 to
b382384
Compare
veetragjain
marked this pull request as ready for review
August 21, 2026 15:16
veetragjain
enabled auto-merge
August 21, 2026 16:25
davidkaplanbitgo
approved these changes
Aug 21, 2026
abhi-bitgo
reviewed
Aug 24, 2026
Comment on lines
+596
to
+597
| use crate::fixed_script_wallet::bitgo_psbt::zcash_psbt::IronwoodOutputRequest; | ||
| use crate::zcash::ironwood_build::{AnchorBytes, ANCHOR_SIZE}; |
There was a problem hiding this comment.
nit: is there a reason for not importing at the top and doing it inline? I feel like we can move this to the top
abhi-bitgo
reviewed
Aug 24, 2026
|
|
||
| impl TryFromJsValue for crate::fixed_script_wallet::bitgo_psbt::zcash_psbt::IronwoodOutputRequest { | ||
| fn try_from_js_value(item: &JsValue) -> Result<Self, WasmUtxoError> { | ||
| use crate::zcash::ironwood_build::{MemoBytes, OrchardAddressBytes, OvkBytes}; |
Contributor
Author
There was a problem hiding this comment.
Sure, will do it in next PR
abhi-bitgo
approved these changes
Aug 24, 2026
veetragjain
deleted the
veetragjain/cshld-1529-support-multi-recipient-ironwood-shielded-outputs
branch
August 24, 2026 05:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CSHLD-1529