Skip to content

fix(wasm-utxo): enable drop ExtParams in fromStringDetectType#279

Merged
veetragjain merged 1 commit into
masterfrom
veetragjain/cshld-815-fix-wasm-utxo-to-accept-taproot-descriptors-with
May 11, 2026
Merged

fix(wasm-utxo): enable drop ExtParams in fromStringDetectType#279
veetragjain merged 1 commit into
masterfrom
veetragjain/cshld-815-fix-wasm-utxo-to-accept-taproot-descriptors-with

Conversation

@veetragjain
Copy link
Copy Markdown
Contributor

@veetragjain veetragjain commented May 11, 2026

Descriptor.fromStringDetectType was rejecting taproot descriptors containing
payload_drop or r:older because its outer parse_descriptor call used default
ExtParams without the drop flag.

Swap parse_descriptor for parse_descriptor_ext(..., ExtParams::sane().drop())
to match the pattern used elsewhere in the file. ExtParams::sane().drop() is a
strict superset of ExtParams::sane(), so the change is purely additive — every
descriptor that parsed before still parses now.

Adds TS tests in test/sbtc.ts covering fromStringDetectType with payload_drop
and r:older.

Ticket: CSHLD-815

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 11, 2026

CSHLD-815

@veetragjain veetragjain marked this pull request as ready for review May 11, 2026 21:26
@veetragjain veetragjain requested a review from a team as a code owner May 11, 2026 21:26
@veetragjain veetragjain enabled auto-merge May 11, 2026 21:27
@veetragjain veetragjain merged commit af61422 into master May 11, 2026
17 checks passed
@veetragjain veetragjain deleted the veetragjain/cshld-815-fix-wasm-utxo-to-accept-taproot-descriptors-with branch May 11, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants