Draft
Conversation
Document 7 core architectural patterns enforced in code reviews: - Uint8Array for binary data (no hex on Transaction) - bigint for monetary amounts - Enums over magic strings - Builders return Transaction objects - Parsing separate from Transaction - Consistent wrapper API (fromBytes, toBytes, get wasm) - Typed wrappers over string-encoded data These conventions prevent review churn by defining how WASM wrapper APIs should be structured. Distilled from recurring patterns in wasm-utxo, wasm-solana, and wasm-dot reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
documents 7 architectural patterns enforced in code reviews across wasm-utxo, wasm-solana, and wasm-dot.
these are design decisions that could reasonably be made differently but we've standardized on:
distilled from otto's recurring review comments. prevents review churn by making the patterns explicit.
ref: wasm-dot PR #145 discussion about parse convention alignment