refactor: align wasm-solana with wasm-utxo parse conventions#175
Open
refactor: align wasm-solana with wasm-utxo parse conventions#175
Conversation
remove Transaction.parse(), rename parseTransactionData → parseTransaction changes: - remove Transaction.parse() method and parseTransactionData import from transaction.ts - rename parseTransactionData → parseTransaction in parser.ts (returns ParsedTransaction) - update explain.ts to import parseTransaction instead of parseTransactionData - remove top-level parseTransaction function from index.ts (was returning Transaction) - export parseTransaction from parser.ts (returns ParsedTransaction) - update test imports: parseTransactionData as parseTransaction → parseTransaction separation of concerns: - Transaction.fromBytes(bytes) - deserialize for signing - parseTransaction(bytes) - decode into structured data (ParsedTransaction) - explainTransaction(bytes, options) - high-level explanation aligns with wasm-utxo and wasm-dot conventions. 94/94 tests passing. BTC-3063
lcovar
force-pushed
the
BTC-3063.parse-convention
branch
from
7777e5e to
61de736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove Transaction.parse(), rename parseTransactionData → parseTransaction
changes:
separation of concerns:
aligns with wasm-utxo and wasm-dot conventions. 94/94 tests passing.
BTC-3063