Skip to content

Comments

fix(express): restore backward compatibility for empty eip1559 object#8171

Merged
Marzooqa merged 1 commit intomasterfrom
WP-7882
Feb 23, 2026
Merged

fix(express): restore backward compatibility for empty eip1559 object#8171
Marzooqa merged 1 commit intomasterfrom
WP-7882

Conversation

@Marzooqa
Copy link
Contributor

@Marzooqa Marzooqa commented Feb 18, 2026

Summary

  • Restores backward compatibility for clients sending eip1559: {}
  • Adds validation to reject partial eip1559 objects (only one of
    maxFeePerGas/maxPriorityFeePerGas)
  • Applies to both /sendcoins and /sendmany endpoints

Changes

  • Updated EIP1559Params schema to use t.partial for flexible input validation
  • Added controller-level validation with clear error messages:
    • eip1559 missing maxPriorityFeePerGas
    • eip1559 missing maxFeePerGas
  • Empty eip1559: {} is normalized to undefined.
  • Added tests for backward compatibility and partial object rejection

TICKET: WP-7882

@Marzooqa Marzooqa marked this pull request as ready for review February 19, 2026 07:09
@Marzooqa Marzooqa requested review from a team as code owners February 19, 2026 07:09
Copy link
Contributor

@alextse-bg alextse-bg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

@Marzooqa Marzooqa requested a review from alextse-bg February 20, 2026 10:55
@Marzooqa Marzooqa merged commit 45536c9 into master Feb 23, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants