Skip to content

fix(sdk-coin-sol): add early validation for transaction size limits#7789

Closed
nvrakesh06 wants to merge 1 commit intomasterfrom
WIN-8401-1
Closed

fix(sdk-coin-sol): add early validation for transaction size limits#7789
nvrakesh06 wants to merge 1 commit intomasterfrom
WIN-8401-1

Conversation

@nvrakesh06
Copy link
Contributor

TICKET: WIN-8401

Add transaction size validation to prevent buffer overflow errors when sending to too many recipients

@nvrakesh06 nvrakesh06 force-pushed the WIN-8401-1 branch 2 times, most recently from 3682a3b to 8af5ae6 Compare December 22, 2025 13:19
@nvrakesh06 nvrakesh06 marked this pull request as ready for review December 26, 2025 08:46
@nvrakesh06 nvrakesh06 requested a review from a team as a code owner December 26, 2025 08:46
@nvrakesh06
Copy link
Contributor Author

Ref:
#7785
#7805

@at31416
Copy link
Contributor

at31416 commented Dec 26, 2025

can there be a transaction which has both the cases of with and without ata creation?

@nvrakesh06
Copy link
Contributor Author

@at31416 good catch, you’re right, I completely missed that case. If we start explicitly handling every edge case here, it’ll quickly get messy and hard to maintain.

I’m leaning towards letting the Solana SDK surface the error as-is (since it’s the source of truth). Do you think we should keep it that way, or wrap it in a higher-level BitGo error with a cleaner message/context?

@at31416
Copy link
Contributor

at31416 commented Jan 2, 2026

I’m leaning towards letting the Solana SDK surface the error as-is (since it’s the source of truth). Do you think we should keep it that way, or wrap it in a higher-level BitGo error with a cleaner message/context?

imo we should wrap it in a cleaner error message if possible.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Feb 17, 2026
@github-actions
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants