fix(sdk-coin-sol): add early validation for transaction size limits#7789
fix(sdk-coin-sol): add early validation for transaction size limits#7789nvrakesh06 wants to merge 1 commit intomasterfrom
Conversation
3682a3b to
8af5ae6
Compare
8af5ae6 to
e2c71f5
Compare
|
can there be a transaction which has both the cases of with and without ata creation? |
|
@at31416 good catch, you’re right, I completely missed that case. If we start explicitly handling every edge case here, it’ll quickly get messy and hard to maintain. I’m leaning towards letting the Solana SDK surface the error as-is (since it’s the source of truth). Do you think we should keep it that way, or wrap it in a higher-level BitGo error with a cleaner message/context? |
imo we should wrap it in a cleaner error message if possible. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
TICKET: WIN-8401
Add transaction size validation to prevent buffer overflow errors when sending to too many recipients