backend: handle AOPP Signing abort by user for BTC.#3848
Merged
bznein merged 1 commit intoBitBoxSwiss:masterfrom Feb 9, 2026
Merged
backend: handle AOPP Signing abort by user for BTC.#3848bznein merged 1 commit intoBitBoxSwiss:masterfrom
bznein merged 1 commit intoBitBoxSwiss:masterfrom
Conversation
We need to check for error before returning, otherwise signResult will be nil and we can't dereference it. Furthermore, we return a specific ErrSigningAborted in case the user aborted the signing. In the aopp code, we change the condition to check for ErrSigningAborted rather than ErrorAbort from the firmware package. This also aligns with how we handle aborting an ETH Sign Message. We extract common code shared between ETH and BTC to make it less likely to have the same error/discrepancy in the future.
Collaborator
Author
|
@codex review |
Collaborator
Author
|
Added @thisconnect as reviewer to test it (since he reported the issue originally) and @benma since it changes backend logic. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
thisconnect
approved these changes
Feb 9, 2026
Collaborator
thisconnect
left a comment
thisconnect
left a comment
There was a problem hiding this comment.
tested Qt / macOS LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to check for error before returning, otherwise signResult will be nil and we can't dereference it. Furthermore, we return a specific ErrSigningAborted in case the user aborted the signing.
In the aopp code, we change the condition to check for ErrSigningAborted rather than ErrorAbort from the firmware package. This also aligns with how we handle aborting an ETH Sign Message.
We extract common code shared between ETH and BTC to make it less likely to have the same error/discrepancy in the future.
Before asking for reviews, here is a check list of the most common things you might need to consider: