backend: return error message from Etherscan.#3847
Merged
bznein merged 1 commit intoBitBoxSwiss:masterfrom Apr 1, 2026
Merged
Conversation
If we return the unmarshaling error, the fronted might show the user an error that is confusing and not helpful. By returning the actual error, there is a change the user might figure out what's wrong on their own. And even if they don't, it would be easier for support to troubleshoot.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

If we return the unmarshaling error, the fronted might show the user an error that is confusing and not helpful. By returning the actual error, there is a change the user might figure out what's wrong on their own. And even if they don't, it would be easier for support to troubleshoot.
Before asking for reviews, here is a check list of the most common things you might need to consider: