Skip to content

backend: return error message from Etherscan.#3847

Merged
bznein merged 1 commit intoBitBoxSwiss:masterfrom
bznein:etherscanError
Apr 1, 2026
Merged

backend: return error message from Etherscan.#3847
bznein merged 1 commit intoBitBoxSwiss:masterfrom
bznein:etherscanError

Conversation

@bznein
Copy link
Copy Markdown
Collaborator

@bznein bznein commented Feb 5, 2026

If we return the unmarshaling error, the fronted might show the user an error that is confusing and not helpful. By returning the actual error, there is a change the user might figure out what's wrong on their own. And even if they don't, it would be easier for support to troubleshoot.

Before asking for reviews, here is a check list of the most common things you might need to consider:

  • updating the Changelog
  • writing unit tests
  • checking if your changes affect other coins or tokens in unintended ways
  • testing on multiple environments (Qt, Android, ...)
  • having an AI review your changes

If we return the unmarshaling error, the fronted might show the user an
error that is confusing and not helpful. By returning the actual error,
there is a change the user might figure out what's wrong on their own.
And even if they don't, it would be easier for support to troubleshoot.
@bznein bznein requested a review from thisconnect February 5, 2026 10:19
@thisconnect
Copy link
Copy Markdown
Collaborator

thisconnect commented Mar 31, 2026

Tested very nice, I patched an older version 4.47.2 as you suggested
(Note: can't use a nova for testing 😅 )

this error is looks very useful (compared to unmarshal)

Screenshot 2026-03-31 at 17 18 32

@bznein bznein marked this pull request as ready for review March 31, 2026 15:33
@bznein bznein requested a review from Beerosagos March 31, 2026 15:34
Copy link
Copy Markdown
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@bznein bznein merged commit 0b6dcd5 into BitBoxSwiss:master Apr 1, 2026
16 checks passed
@bznein bznein deleted the etherscanError branch April 1, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants