frontend: show offline error and scanning info on account-summary #3749
Draft
thisconnect wants to merge 5 commits intoBitBoxSwiss:masterfrom
Draft
frontend: show offline error and scanning info on account-summary #3749thisconnect wants to merge 5 commits intoBitBoxSwiss:masterfrom
thisconnect wants to merge 5 commits intoBitBoxSwiss:masterfrom
Conversation
Changed the component to work standalone without necessity to have the parent component subscribe to status changed events.
Changed to show offlineError message in the account-summary view, for example if the node cannot be reached or is misconfigured. Also added 'scanning blockchain' string which is shown for account based blockchains or before address scanning started.
In case when status.synced is true but the balance on account summary is not ready fallback to 'scanning blockchain' message.
Collaborator
Author
|
Tested by removing different files/dirs in appfolder.dev and misconfiguring ltc node. I'm not sure about the last commit. There seems to be a brief situation where status.synced is true, but it's not read to render the balance yet. I'm not sure what it is doing. For this case it is better to fallback to "scanning blockchain" than showing empty space. |
Collaborator
Author
|
Collaborator
Author
|
when offline (not sure why the eth status.offlineError doesn't contain the error.) 
|
Collaborator
|
Isn't it better to see the last known balance and a more subtle warning somewhere else for connection status? Like for example to the left of the "hide/show balances eye"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before asking for reviews, here is a check list of the most common things you might need to consider: