Add NGN and ZAR fiat currencies#2214
Open
Zero-1729 wants to merge 2 commits intoBitBoxSwiss:masterfrom
Open
Conversation
Note: currency included in CoinGecko supported fiat list: https://api.coingecko.com/api/v3/simple/supported_vs_currencies - added NGN fiat code - added NGN to account fiat list - added NGN to fiat currencies list - added NGN to balance and fee tests - Updated CHANGELOG to reflect addition.
Note: currency included in CoinGecko supported fiat list: https://api.coingecko.com/api/v3/simple/supported_vs_currencies - added ZAR fiat code - added ZAR to account fiat list - added ZAR to fiat currencies list - added ZAR to balance and fee tests - Updated CHANGELOG to reflect addition.
Contributor
|
Thanks for your contribution! Unfortunately we cannot merge this for the time being as we first need to make optimizations to our currency conversion backend, which is feeling the load of all the currency pairs currently supported! It's not clear when we will get to this either, as it's quite low prio at the moment. |
Collaborator
|
Unfortunately we never received any other requests from users to add NGN and ZAR to the BitBoxApp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Nigerian Naira (NGN) and South African Rand (ZAR).
CoinGecko supports both currencies, see https://api.coingecko.com/api/v3/simple/supported_vs_currencies.