Skip to content

Change GetInfo disabled tests to start new connection#159

Merged
alinaliBQ merged 2 commits intoapache-odbcfrom
fix-get-info-tests
Mar 10, 2026
Merged

Change GetInfo disabled tests to start new connection#159
alinaliBQ merged 2 commits intoapache-odbcfrom
fix-get-info-tests

Conversation

@alinaliBQ
Copy link

@alinaliBQ alinaliBQ commented Mar 9, 2026

Changed tests TestSQLGetInfoCatalogLocation, TestSQLGetInfoDropSchema, and TestSQLGetInfoDropTable to start a new connection, this fixes the test failures.

This PR fixes:

[  FAILED  ] ConnectionInfoTest/0.TestSQLGetInfoDropSchema, where TypeParam = arrow::flight::sql::odbc::ConnectionInfoMockTest
[  FAILED  ] ConnectionInfoTest/0.TestSQLGetInfoDropTable, where TypeParam = arrow::flight::sql::odbc::ConnectionInfoMockTest
[  FAILED  ] ConnectionInfoTest/1.TestSQLGetInfoCatalogLocation, where TypeParam = arrow::flight::sql::odbc::FlightSQLODBCRemoteTestBaseis the result.

Note that the other cases of ConnectionInfoTest/1.TestSQLGetInfoDropSchema, ConnectionInfoTest/1.TestSQLGetInfoDropTable, and ConnectionInfoTest/0.TestSQLGetInfoCatalogLocation pass successfully.

The root cause is inside flightsql-odbc code. Raised apache#49482 for a permanent fix for the ODBC driver, so the tests may pass with global connection as well.

@alinaliBQ alinaliBQ closed this Mar 9, 2026
@alinaliBQ alinaliBQ reopened this Mar 9, 2026
@alinaliBQ alinaliBQ marked this pull request as ready for review March 9, 2026 22:20
@alinaliBQ alinaliBQ force-pushed the fix-get-info-tests branch from 8ac7770 to 4d0619c Compare March 10, 2026 18:03
Copy link

@jduo jduo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revise the title of the PR and the description to be more clear about what this is changing and why.

Copy link

@jduo jduo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once comments are addressed.

@alinaliBQ alinaliBQ changed the title Enable DISABLE_TEST by single connection Change DISABLE_TESTS to start new connection Mar 10, 2026
@alinaliBQ alinaliBQ changed the title Change DISABLE_TESTS to start new connection Change GetInfo disabled tests to start new connection Mar 10, 2026
@alinaliBQ alinaliBQ merged commit cc41aae into apache-odbc Mar 10, 2026
24 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants