Change GetInfo disabled tests to start new connection#159
Merged
alinaliBQ merged 2 commits intoapache-odbcfrom Mar 10, 2026
Merged
Change GetInfo disabled tests to start new connection#159alinaliBQ merged 2 commits intoapache-odbcfrom
GetInfo disabled tests to start new connection#159alinaliBQ merged 2 commits intoapache-odbcfrom
Conversation
8ac7770 to
4d0619c
Compare
jduo
reviewed
Mar 10, 2026
jduo
left a comment
There was a problem hiding this comment.
Please revise the title of the PR and the description to be more clear about what this is changing and why.
jduo
approved these changes
Mar 10, 2026
jduo
left a comment
There was a problem hiding this comment.
Looks good once comments are addressed.
DISABLE_TEST by single connectionDISABLE_TESTS to start new connection
DISABLE_TESTS to start new connectionGetInfo disabled tests to start new connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed tests
TestSQLGetInfoCatalogLocation,TestSQLGetInfoDropSchema, andTestSQLGetInfoDropTableto start a new connection, this fixes the test failures.This PR fixes:
Note that the other cases of
ConnectionInfoTest/1.TestSQLGetInfoDropSchema,ConnectionInfoTest/1.TestSQLGetInfoDropTable, andConnectionInfoTest/0.TestSQLGetInfoCatalogLocationpass successfully.The root cause is inside
flightsql-odbccode. Raised apache#49482 for a permanent fix for the ODBC driver, so the tests may pass with global connection as well.