SVGRenderer replacement and jbrowse version update #380
+3,278
−1,979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| import DisplayType from '@jbrowse/core/pluggableElementTypes/DisplayType'; | ||
| import { createBaseTrackModel } from '@jbrowse/core/pluggableElementTypes/models'; | ||
|
|
||
| import CanvasFeatureRenderer from "@jbrowse/plugin-canvas"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files:
and the changes in jbrowse/src/client/JBrowse/Search/components/StandaloneSearchComponent.tsx
are temporary, pending a PR or two upstream. We need @jbrowse/components to export the fetchResults function. The @GMOD patches fix a weird interaction between our LabKey/Tomcat Content Security Policy headers and the way those packages do their WASM loading, which they just implemented for fast gunzipping.
The rest replaces ExtendedVariantRenderer with a default CanvasFeatureRenderer and moves all the relevant state for InfoFilters and activeSamples over to the ExtendedVariantDisplay. This required incrementing our jbrowse major version which had impacts all over the place. I'll move this out of draft status once I have an answer on some of the changes we need upstream and I have the JBrowse tests passing (most of the selenium stuff related to clicking on SNVs is broken.)