Open
Conversation
8acf945 to
67f0dcc
Compare
Contributor
Author
|
OK, I did some additional testing, and it seems that the issue I was running into where all |
piedoom
commented
Dec 14, 2025
|
|
||
| /// Read the least recent sample pushed to this delay line (the sample that | ||
| /// will be replaced with the next [`Self::write_and_advance`]). | ||
| pub fn read_last(&self) -> f64 { |
Contributor
Author
There was a problem hiding this comment.
all of this can use some bikeshedding, idk if these are correct terms
added back stopping. pause still strange, time changing still can click smoothed filter values
…ixed wrapping issue causing occasional panics. Separated delay line into dsp.
…cessary config field
Contributor
Author
|
Added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drafting to track #16 - some things to fix, but I think this is close. Still need to fix issues with pause behavior and time change clicking,
as well as smoothing filter values (done). There also may be some performance improvements to be made, especially with how I am handling interpolating between times.I modeled this after what I presume is happening with Bitwig's delay effect, which allows for both single echos and feedback delays.
Issue criteria:
tap_gain- I found this was redundant with themixandfeedbackfeedback_lpf. I think feedback is more generally understood than tap (and should be more accurate in this case as well).feedback_hpffor above reasonenabled- Not needed withmixsettingAdditional features
Tradeoffs