[codex] Add macOS native menu shortcuts#4100
Open
gjxwxt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Cmd+Hmapped to hide the app windowsCmd+Wmapped to hide the active windowCmd+Qas an explicit application quit actionWhy
The macOS build only registered a minimal native menu, so standard macOS shortcuts like
Cmd+H,Cmd+W, andCmd+Qwere not fully wired into the application lifecycle.Impact
macOS users now get the expected shortcut behavior:
Cmd+Hhides the app windowsCmd+Whides the current window instead of acting like quitCmd+Qstill exits the appRoot cause
The app-level
NativeMenuonly exposed Settings and Exit, and the main window behavior relied on close interception rather than native macOS menu shortcut bindings.Validation
git diff --checkdotnet build src/BD.WTTS.Client.Avalonia.App/BD.WTTS.Client.Avalonia.App.csproj, butdotnetis not installed in this environment