Load rather than push untested image#3
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the CI/CD build workflow to use Docker image artifacts instead of pushing untested images directly to the registry. The change improves the workflow by ensuring only tested images are pushed to the container registry.
Key changes:
- Replace direct Docker push with artifact-based image storage and loading
- Add artifact upload/download steps to transfer the Docker image between jobs
- Update job outputs to reference the new artifact naming
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.github/workflows/build.yml
Outdated
| run: | | ||
| docker load --input ${{ runner.temp }}/${{ needs.build.outputs.build-artifact }} | ||
| docker image ls -a | ||
| false |
There was a problem hiding this comment.
The false command will always cause the step to fail. This appears to be debugging code that should be removed before merging.
| false |
.github/workflows/build.yml
Outdated
| cache-from: type=gha | ||
| cache-to: type=gha | ||
| labels: ${{ steps.build-meta.outputs.labels }} | ||
| outputs: type=docker,dest=${{ runner.temp }}/iipsrv-${{ steps.build-meta.outputs.tags }}.tar |
There was a problem hiding this comment.
[nitpick] The artifact filename pattern iipsrv-${{ steps.build-meta.outputs.tags }}.tar is duplicated across multiple lines. Consider extracting this to an environment variable or job output to reduce duplication and potential inconsistencies.
.github/workflows/build.yml
Outdated
| name: iipsrv-${{ steps.build-meta.outputs.tags }}.tar | ||
| path: ${{ runner.temp }}/iipsrv-${{ steps.build-meta.outputs.tags }}.tar |
There was a problem hiding this comment.
[nitpick] The artifact filename pattern iipsrv-${{ steps.build-meta.outputs.tags }}.tar is duplicated across multiple lines. Consider extracting this to an environment variable or job output to reduce duplication and potential inconsistencies.
danschmidt5189
force-pushed
the
better-caching
branch
4 times, most recently
from
bf28c3b to
08efd4b
Compare
danschmidt5189
force-pushed
the
better-caching
branch
from
08efd4b to
6a8bcc7
Compare
1 participant
No description provided.