Fix discount factor to avoid ambiguity with transition probabilities#9
Open
ethanelasky wants to merge 1 commit intoBerkeleyAI:mainfrom
Open
Fix discount factor to avoid ambiguity with transition probabilities#9ethanelasky wants to merge 1 commit intoBerkeleyAI:mainfrom
ethanelasky wants to merge 1 commit intoBerkeleyAI:mainfrom
Conversation
Change discount factor from γ = 0.5 to γ = 0.8 in both value iteration and policy iteration examples. This helps students pattern-match formula to worked example better and helps them avoid mixing up the 0.5 in the discount factor with the 0.5 transition probabilities used by the racecar example. Updated all example calculations and values accordingly to maintain correctness with the new discount factor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The racecar MDP example uses transition probabilities of 0.5 in several places. When the discount factor is also 0.5, it creates ambiguity - students cannot easily pattern-match 0.5 and determine which represents T(s,a,s') (transition probability) and which represents γ (discount factor) in the Bellman equations.
For example, with γ = 0.5:
With γ = 0.8:
This change improves clarity for students learning MDP algorithms.
Changes