Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
name: PHPStan
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: PHPStan
uses: docker://oskarstark/phpstan-ga:1.8.0
uses: docker://oskarstark/phpstan-ga
Comment thread
garak marked this conversation as resolved.
env:
REQUIRE_DEV: true
with:
Expand All @@ -24,7 +24,7 @@ jobs:
name: PHP-CS-Fixer
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Fix CS
uses: docker://oskarstark/php-cs-fixer-ga
with:
Expand All @@ -37,7 +37,8 @@ jobs:
include:
- description: 'Symfony 6.4'
php: '8.1'
composer_option: '--prefer-lowest'
symfony: 6.4.*
dependencies: lowest
max_deprecations: 0
- description: 'Symfony 6.4'
php: '8.2'
Expand All @@ -58,24 +59,21 @@ jobs:
name: PHP ${{ matrix.php }} tests (${{ matrix.description }})
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Cache
uses: actions/cache@v4
with:
path: ~/.composer/cache/files
key: ${{ matrix.php }}-${{ matrix.symfony }}-${{ matrix.composer_option }}
uses: actions/checkout@v6
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
- run: |
composer config minimum-stability dev
composer config prefer-stable true
tools: flex
- name: Allow dev dependencies
run: composer config minimum-stability dev && composer config prefer-stable true
if: contains(matrix.symfony, '@dev')
- run: |
sed -ri 's/"symfony\/(config|dependency-injection|form|http-kernel|validator)": "(.+)"/"symfony\/\1": "'${{ matrix.symfony }}'"/' composer.json;
if: matrix.symfony
- run: composer update --no-interaction --no-progress --ansi ${{ matrix.composer_option }}
- name: Install dependencies
uses: ramsey/composer-install@v3
with:
dependency-versions: ${{ matrix.dependencies }}
Comment thread
garak marked this conversation as resolved.
env:
SYMFONY_REQUIRE: ${{ matrix.symfony }}
Comment thread
garak marked this conversation as resolved.
- name: Run tests
run: vendor/bin/phpunit --colors=always --coverage-clover=clover.xml
env:
Expand Down
3 changes: 3 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"symfony/http-client-contracts": "^3.5",
"symfony/phpunit-bridge": "^7.4"
},
"conflict": {
"google/recaptcha": "1.5.0"
},
"suggest": {
"symfony/twig-bundle": "To render widget. Minimum supported Twig version is 2.4"
},
Expand Down
Empty file removed phpstan-baseline.neon
Empty file.
2 changes: 0 additions & 2 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ parameters:
- config
- src
- tests
includes:
- phpstan-baseline.neon
2 changes: 1 addition & 1 deletion src/DependencyInjection/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public function getConfigTreeBuilder(): TreeBuilder
{
$treeBuilder = new TreeBuilder('beelab_recaptcha2');
$rootNode = $treeBuilder->getRootNode();
$rootNode // @phpstan-ignore-line method.notFound
$rootNode
->children()
->enumNode('request_method')
->values(['curl_post', 'post', 'http_client'])
Expand Down
16 changes: 16 additions & 0 deletions src/Validator/Constraints/Recaptcha2.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,22 @@ final class Recaptcha2 extends Constraint

public string $message = 'Invalid ReCaptcha.';

public function __construct(
mixed $options = null,
?array $groups = null,
mixed $payload = null,
?string $message = null,
) {
if (null !== $message) {
$this->message = $message;
}
if (\is_array($options)) {
trigger_deprecation('beelab/recaptcha2-bundle', '2.13', 'Passing options as an array is deprecated. Pass options as named arguments instead.');
$options['message'] = $this->message;
}
parent::__construct($options, $groups, $payload);
}

public function validatedBy(): string
{
return 'recaptcha2';
Expand Down
8 changes: 4 additions & 4 deletions tests/DependencyInjection/BeelabRecaptcha2ExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ final class BeelabRecaptcha2ExtensionTest extends TestCase
{
public function testLoadSetParameters(): void
{
/** @var ContainerBuilder|\PHPUnit\Framework\MockObject\MockObject $container */
/** @var ContainerBuilder&\PHPUnit\Framework\MockObject\MockObject $container */
$container = $this->createMock(ContainerBuilder::class);
/** @var ParameterBag|\PHPUnit\Framework\MockObject\MockObject $parameterBag */
/** @var ParameterBag&\PHPUnit\Framework\MockObject\MockObject $parameterBag */
$parameterBag = $this->createMock(ParameterBag::class);

$parameterBag->method('add');
Expand All @@ -35,9 +35,9 @@ public function testLoadSetParameters(): void

public function testLoadSetParametersPost(): void
{
/** @var ContainerBuilder|\PHPUnit\Framework\MockObject\MockObject $container */
/** @var ContainerBuilder&\PHPUnit\Framework\MockObject\MockObject $container */
$container = $this->createMock(ContainerBuilder::class);
/** @var ParameterBag|\PHPUnit\Framework\MockObject\MockObject $parameterBag */
/** @var ParameterBag&\PHPUnit\Framework\MockObject\MockObject $parameterBag */
$parameterBag = $this->createMock(ParameterBag::class);

$parameterBag->method('add');
Expand Down
Loading