Closes #5344: ArkoudaExtensionArray.view#5345
Merged
ajpotts merged 3 commits intoBears-R-Us:mainfrom Jan 27, 2026
Merged
Conversation
6fc3bbe to
e8982af
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5345 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 109
Branches ? 0
========================================
Hits ? 109
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e8982af to
3a87580
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements view() for ArkoudaExtensionArray, aligning Arkouda’s pandas ExtensionArray behavior with pandas’ expectations around shallow copies. This resolves failures triggered by pandas internals (e.g. BlockManager.copy(deep=False)) that previously raised NotImplementedError.
The new implementation returns a shallow wrapper that shares the same underlying Arkouda server-side data while preserving optional internal metadata. No data is materialized or copied unless an explicit dtype conversion is requested.
Key Changes
Why This Matters
Pandas frequently relies on .view() for shallow copies during internal operations. Without this method, valid workflows (e.g. constructing a DataFrame from a Series backed by Arkouda) could fail unexpectedly. This change restores compatibility without introducing unnecessary data movement.
Testing
Backward Compatibility
This is a strict improvement:
Closes #5344: ArkoudaExtensionArray.view