pandas extension update: adding Categorical to the isnull function
#5337
+85
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5337 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 115
Branches ? 0
========================================
Hits ? 115
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jaketrookman
force-pushed
the
isnull_pandas_extension
branch
from
08d6b78 to
c6477b5
Compare
jaketrookman
force-pushed
the
isnull_pandas_extension
branch
7 times, most recently
from
565b977 to
4f5a1f8
Compare
jaketrookman
force-pushed
the
isnull_pandas_extension
branch
from
4f5a1f8 to
d899a15
Compare
jaketrookman
changed the title
Categorical to the isnull function
ajpotts
reviewed
Jan 29, 2026
|
|
||
| return zeros(self._data.size, dtype=bool_) | ||
|
|
||
| def isnull(self): |
Contributor
There was a problem hiding this comment.
isnull should return an ExtensionArray. In this case it would be an ArkoudaArray (numerical/bool). In general, the pandas extension array API allows numpy/ExtensionArray/numpy scalar outputs. Make sure the return type is included in the signature and in the docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ads Categorical functionality to
isnullthrough theisnafunction.Adds tests