perf(encode,decode): skip reflect.Convert for exact map/slice types#51
Merged
perf(encode,decode): skip reflect.Convert for exact map/slice types#51
Conversation
Adds v.Type() == targetType fast path before v.Convert() in map and
slice encode/decode functions. Convert is only needed for named types
(e.g. type M map[string]string); for exact type matches it's pure
overhead. Applies to map[string]string, map[string]bool,
map[string]interface{}, and []string paths.
Benchmark improvements:
StringSlice: 85 ns -> 79 ns (-7%)
MapStringString: 192 ns -> 176 ns (-8%)
MapStringStringPtr: 217 ns -> 205 ns (-6%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v.Type() == targetTypefast path beforev.Convert()in map and slice encode/decode functionsConvertis only needed for named types (e.g.,type M map[string]string); for exact type matches it's pure overheadmap[string]string,map[string]bool,map[string]interface{}, and[]stringpathsBenchmark Results
Test plan