Await store.putFile so cache info is persisted #492 - #518
Open
AzazelSensei wants to merge 1 commit into
Open
Conversation
putFile, putFileStream, and downloads started persist without waiting. After those calls returned, CacheObject.id could still be null, so removeFile skipped the entry and a process exit could lose the info. Fixes Baseflow#492
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
putFile,putFileStream, andWebHelperstartstore.putFileand return without waiting. The file is on disk, but the cache-info row (and its id) may not be written yet.That matches #492:
removeFileaftergetFileStreamcan no-op becauseCacheObject.idis still null, and a crash right after download can drop the entry.🆕 What is the new behavior (if this is a feature change)?
Those paths now await persist. After they complete, the store has the object and an id, so a follow-up
removeFileactually deletes it.💥 Does this PR introduce a breaking change?
No. Callers already treat these as
Futures. They just wait a bit longer for the existing database write.🐛 Recommendations for testing
flutter testinflutter_cache_manager. New cases delaystore.putFileand fail if the caller returns early.📝 Links to relevant issues/docs
Fixes #492
🤔 Checklist before submitting